Skip to content

Commit da48708

Browse files
committed
Merge tag 'thunderbolt-for-v6.7-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt into usb-linus
Mika writes: thunderbolt: Fixes for v6.7-rc6 This includes following USB4/Thunderbolt fixes for v6.7-rc6: - Fix memory leak in margining_port_remove() - Correct minimum bandwidth allocated for USB 3.x and PCIe to avoid reducing DisplayPort capabilities in certain monitor configurations. Both have been in linux-next with no reported issues. * tag 'thunderbolt-for-v6.7-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt: thunderbolt: Fix minimum allocated USB 3.x and PCIe bandwidth thunderbolt: Fix memory leak in margining_port_remove()
2 parents a39b6ac + f0b94c1 commit da48708

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

drivers/thunderbolt/debugfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -959,7 +959,7 @@ static void margining_port_remove(struct tb_port *port)
959959
snprintf(dir_name, sizeof(dir_name), "port%d", port->port);
960960
parent = debugfs_lookup(dir_name, port->sw->debugfs_dir);
961961
if (parent)
962-
debugfs_remove_recursive(debugfs_lookup("margining", parent));
962+
debugfs_lookup_and_remove("margining", parent);
963963

964964
kfree(port->usb4->margining);
965965
port->usb4->margining = NULL;

drivers/thunderbolt/usb4.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2311,13 +2311,13 @@ int usb4_usb3_port_release_bandwidth(struct tb_port *port, int *upstream_bw,
23112311
goto err_request;
23122312

23132313
/*
2314-
* Always keep 1000 Mb/s to make sure xHCI has at least some
2314+
* Always keep 900 Mb/s to make sure xHCI has at least some
23152315
* bandwidth available for isochronous traffic.
23162316
*/
2317-
if (consumed_up < 1000)
2318-
consumed_up = 1000;
2319-
if (consumed_down < 1000)
2320-
consumed_down = 1000;
2317+
if (consumed_up < 900)
2318+
consumed_up = 900;
2319+
if (consumed_down < 900)
2320+
consumed_down = 900;
23212321

23222322
ret = usb4_usb3_port_write_allocated_bandwidth(port, consumed_up,
23232323
consumed_down);

0 commit comments

Comments
 (0)