Skip to content

Commit d92e9ea

Browse files
Faboandersson
authored andcommitted
arm64: dts: qcom: msm8939: revert use of APCS mbox for RPM
Commit 22e4e43 ("arm64: dts: qcom: msm8939: Use mboxes properties for APCS") broke the boot on msm8939 platforms. The issue comes from the SMD driver failing to request the mbox channel because of circular dependencies: 1. rpm -> apcs1_mbox -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm. 2. rpm -> apcs1_mbox -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm 3. rpm -> apcs1_mbox -> apcs2 -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm To fix this issue let's switch back to using the deprecated qcom,ipc property for the RPM node. Fixes: 22e4e43 ("arm64: dts: qcom: msm8939: Use mboxes properties for APCS") Signed-off-by: Fabien Parent <fabien.parent@linaro.org> Link: https://lore.kernel.org/r/20240904-msm8939-rpm-apcs-fix-v1-1-b608e7e48fe1@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent dfbe93f commit d92e9ea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm64/boot/dts/qcom/msm8939.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@
248248

249249
smd-edge {
250250
interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
251-
mboxes = <&apcs1_mbox 0>;
251+
qcom,ipc = <&apcs1_mbox 8 0>;
252252
qcom,smd-edge = <15>;
253253

254254
rpm_requests: rpm-requests {

0 commit comments

Comments
 (0)