Skip to content

Commit d929b2b

Browse files
jpanisbltmlind
authored andcommitted
bus: ti-sysc: Use fsleep() instead of usleep_range() in sysc_reset()
The am335x-evm started producing boot errors because of subtle timing changes: Unhandled fault: external abort on non-linefetch (0x1008) at 0xf03c1010 ... sysc_reset from sysc_probe+0xf60/0x1514 sysc_probe from platform_probe+0x5c/0xbc ... The fix consists in using the appropriate sleep function in sysc reset. For flexible sleeping, fsleep is recommended. Here, sysc delay parameter can take any value in [0 - 255] us range. As a result, fsleep() should be used, calling udelay() for a sysc delay lower than 10 us. Signed-off-by: Julien Panis <jpanis@baylibre.com> Fixes: e709ed7 ("bus: ti-sysc: Fix missing reset delay handling") Message-ID: <20230821-fix-ti-sysc-reset-v1-1-5a0a5d8fae55@baylibre.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
1 parent 0bb80ec commit d929b2b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/bus/ti-sysc.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2150,8 +2150,7 @@ static int sysc_reset(struct sysc *ddata)
21502150
}
21512151

21522152
if (ddata->cfg.srst_udelay)
2153-
usleep_range(ddata->cfg.srst_udelay,
2154-
ddata->cfg.srst_udelay * 2);
2153+
fsleep(ddata->cfg.srst_udelay);
21552154

21562155
if (ddata->post_reset_quirk)
21572156
ddata->post_reset_quirk(ddata);

0 commit comments

Comments
 (0)