Skip to content

Commit d844c64

Browse files
rtc: wm8350: remove unnecessary messages
The RTC core already prints a message when the RTC is registered and when registering fails, it is not necessary to have more in the driver. Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://lore.kernel.org/r/20230827221643.544259-3-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 8805bac commit d844c64

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

drivers/rtc/rtc-wm8350.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,6 @@ static int wm8350_rtc_probe(struct platform_device *pdev)
386386
/* enable the RTC if it's not already enabled */
387387
power5 = wm8350_reg_read(wm8350, WM8350_POWER_MGMT_5);
388388
if (!(power5 & WM8350_RTC_TICK_ENA)) {
389-
dev_info(wm8350->dev, "Starting RTC\n");
390-
391389
wm8350_reg_unlock(wm8350);
392390

393391
ret = wm8350_set_bits(wm8350, WM8350_POWER_MGMT_5,
@@ -426,11 +424,8 @@ static int wm8350_rtc_probe(struct platform_device *pdev)
426424

427425
wm_rtc->rtc = devm_rtc_device_register(&pdev->dev, "wm8350",
428426
&wm8350_rtc_ops, THIS_MODULE);
429-
if (IS_ERR(wm_rtc->rtc)) {
430-
ret = PTR_ERR(wm_rtc->rtc);
431-
dev_err(&pdev->dev, "failed to register RTC: %d\n", ret);
432-
return ret;
433-
}
427+
if (IS_ERR(wm_rtc->rtc))
428+
return PTR_ERR(wm_rtc->rtc);
434429

435430
ret = wm8350_register_irq(wm8350, WM8350_IRQ_RTC_SEC,
436431
wm8350_rtc_update_handler, 0,

0 commit comments

Comments
 (0)