Skip to content

Commit d792a7a

Browse files
amer-hamzaacmel
authored andcommitted
perf session: Check for NULL pointer before dereference
Move NULL pointer check before dereferencing the variable. Addresses-Coverity: 1497622 ("Derereference before null check") Reviewed-by: James Clark <james.clark@arm.com> Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com> Cc: German Gomez <german.gomez@arm.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Riccardo Mancini <rickyman7@gmail.com> Link: https://lore.kernel.org/r/20220125121141.18347-1-amhamza.mgc@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent a663520 commit d792a7a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tools/perf/util/session.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1503,11 +1503,12 @@ static int machines__deliver_event(struct machines *machines,
15031503
++evlist->stats.nr_unknown_id;
15041504
return 0;
15051505
}
1506-
dump_sample(evsel, event, sample, perf_env__arch(machine->env));
15071506
if (machine == NULL) {
15081507
++evlist->stats.nr_unprocessable_samples;
1508+
dump_sample(evsel, event, sample, perf_env__arch(NULL));
15091509
return 0;
15101510
}
1511+
dump_sample(evsel, event, sample, perf_env__arch(machine->env));
15111512
return evlist__deliver_sample(evlist, tool, event, sample, evsel, machine);
15121513
case PERF_RECORD_MMAP:
15131514
return tool->mmap(tool, event, sample, machine);

0 commit comments

Comments
 (0)