Skip to content

Commit d761b94

Browse files
Jason-JH.LinChun-Kuang Hu
authored andcommitted
drm/mediatek: Add cnt checking for coverity issue
CERT-C Characters and Strings (CERT STR31-C) all_drm_priv[cnt] evaluates to an address that could be at negative offset of an array. In mtk_drm_get_all_drm_priv(): Guarantee that storage for strings has sufficient space for character data and the null terminator. So change cnt to unsigned int and check its max value. Fixes: 1ef7ed4 ("drm/mediatek: Modify mediatek-drm for mt8195 multi mmsys support") Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: CK Hu <ck.hu@mediatek.com> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com> Link: https://patchwork.kernel.org/project/dri-devel/patch/20230714094908.13087-3-jason-jh.lin@mediatek.com/ Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
1 parent 27b9e2e commit d761b94

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/gpu/drm/mediatek/mtk_drm_drv.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev)
354354
const struct of_device_id *of_id;
355355
struct device_node *node;
356356
struct device *drm_dev;
357-
int cnt = 0;
357+
unsigned int cnt = 0;
358358
int i, j;
359359

360360
for_each_child_of_node(phandle->parent, node) {
@@ -375,6 +375,9 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev)
375375
all_drm_priv[cnt] = dev_get_drvdata(drm_dev);
376376
if (all_drm_priv[cnt] && all_drm_priv[cnt]->mtk_drm_bound)
377377
cnt++;
378+
379+
if (cnt == MAX_CRTC)
380+
break;
378381
}
379382

380383
if (drm_priv->data->mmsys_dev_num == cnt) {

0 commit comments

Comments
 (0)