scsi: virtio_scsi: Remove duplicate check if queue is broken

lrq-max · martinkpetersen · commit d6b75ba52189 · 2024-01-17T14:46:17.000-05:00
virtqueue_enable_cb() will call virtqueue_poll() which will check if queue is broken at beginning, so remove the virtqueue_is_broken() call Signed-off-by: Li RongQing <lirongqing@baidu.com> Link: https://lore.kernel.org/r/20240116045836.12475-1-lirongqing@baidu.com Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
@@ -182,8 +182,6 @@ static void virtscsi_vq_done(struct virtio_scsi *vscsi,
 		while ((buf = virtqueue_get_buf(vq, &len)) != NULL)
 			fn(vscsi, buf);
 
-		if (unlikely(virtqueue_is_broken(vq)))
-			break;
 	} while (!virtqueue_enable_cb(vq));
 	spin_unlock_irqrestore(&virtscsi_vq->vq_lock, flags);
 }

Original file line number	Diff line number	Diff line change
`@@ -182,8 +182,6 @@ static void virtscsi_vq_done(struct virtio_scsi *vscsi,`
`182`	`182`	`while ((buf = virtqueue_get_buf(vq, &len)) != NULL)`
`183`	`183`	`fn(vscsi, buf);`
`184`	`184`
`185`		`- if (unlikely(virtqueue_is_broken(vq)))`
`186`		`- break;`
`187`	`185`	`} while (!virtqueue_enable_cb(vq));`
`188`	`186`	`spin_unlock_irqrestore(&virtscsi_vq->vq_lock, flags);`
`189`	`187`	`}`