xfs: fix backwards logic in xfs_bmap_alloc_account

Darrick J. Wong · Chandan Babu R · commit d61b40bf15ce · 2024-01-11T10:34:01.000+05:30
We're only allocating from the realtime device if the inode is marked for realtime and we're /not/ allocating into the attr fork. Fixes: 5864346 ("xfs: also use xfs_bmap_btalloc_accounting for RT allocations") Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
@@ -3277,7 +3277,7 @@ xfs_bmap_alloc_account(
 	struct xfs_bmalloca	*ap)
 {
 	bool			isrt = XFS_IS_REALTIME_INODE(ap->ip) &&
-					(ap->flags & XFS_BMAPI_ATTRFORK);
+					!(ap->flags & XFS_BMAPI_ATTRFORK);
 	uint			fld;
 
 	if (ap->flags & XFS_BMAPI_COWFORK) {

Original file line number	Diff line number	Diff line change
`@@ -3277,7 +3277,7 @@ xfs_bmap_alloc_account(`
`3277`	`3277`	`struct xfs_bmalloca *ap)`
`3278`	`3278`	`{`
`3279`	`3279`	`bool isrt = XFS_IS_REALTIME_INODE(ap->ip) &&`
`3280`		`- (ap->flags & XFS_BMAPI_ATTRFORK);`
	`3280`	`+ !(ap->flags & XFS_BMAPI_ATTRFORK);`
`3281`	`3281`	`uint fld;`
`3282`	`3282`
`3283`	`3283`	`if (ap->flags & XFS_BMAPI_COWFORK) {`