Skip to content

Commit d600732

Browse files
LoAnChenalexdeucher
authored andcommitted
drm/amd/display: Fix incorrect fw_state address in dmub_srv
[WHY] The fw_state in dmub_srv was assigned with wrong address. The address was pointed to the firmware region. [HOW] Fix the firmware state by using DMUB_DEBUG_FW_STATE_OFFSET in dmub_cmd.h. Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Signed-off-by: Lo-an Chen <lo-an.chen@amd.com> Signed-off-by: Alex Hung <alex.hung@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit f57b38a)
1 parent acbf16a commit d600732

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ enum dmub_status dmub_srv_hw_init(struct dmub_srv *dmub,
704704
cw6.region.base = DMUB_CW6_BASE;
705705
cw6.region.top = cw6.region.base + fw_state_fb->size;
706706

707-
dmub->fw_state = fw_state_fb->cpu_addr;
707+
dmub->fw_state = (void *)((uintptr_t)(fw_state_fb->cpu_addr) + DMUB_DEBUG_FW_STATE_OFFSET);
708708

709709
region6.offset.quad_part = shared_state_fb->gpu_addr;
710710
region6.region.base = DMUB_CW6_BASE;

0 commit comments

Comments
 (0)