Skip to content

Commit d5d8b9d

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb/dpi: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 26553eb commit d5d8b9d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ static int panel_dpi_probe(struct platform_device *pdev)
211211
return r;
212212
}
213213

214-
static int panel_dpi_remove(struct platform_device *pdev)
214+
static void panel_dpi_remove(struct platform_device *pdev)
215215
{
216216
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
217217
struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -223,8 +223,6 @@ static int panel_dpi_remove(struct platform_device *pdev)
223223
panel_dpi_disconnect(dssdev);
224224

225225
omap_dss_put_device(in);
226-
227-
return 0;
228226
}
229227

230228
static const struct of_device_id panel_dpi_of_match[] = {
@@ -236,7 +234,7 @@ MODULE_DEVICE_TABLE(of, panel_dpi_of_match);
236234

237235
static struct platform_driver panel_dpi_driver = {
238236
.probe = panel_dpi_probe,
239-
.remove = panel_dpi_remove,
237+
.remove_new = panel_dpi_remove,
240238
.driver = {
241239
.name = "panel-dpi",
242240
.of_match_table = panel_dpi_of_match,

0 commit comments

Comments
 (0)