Skip to content

Commit d3a0021

Browse files
Uwe Kleine-KönigJassiBrar
authored andcommitted
mailbox: qcom-ipcc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
1 parent ce42b93 commit d3a0021

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/mailbox/qcom-ipcc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -326,14 +326,12 @@ static int qcom_ipcc_probe(struct platform_device *pdev)
326326
return ret;
327327
}
328328

329-
static int qcom_ipcc_remove(struct platform_device *pdev)
329+
static void qcom_ipcc_remove(struct platform_device *pdev)
330330
{
331331
struct qcom_ipcc *ipcc = platform_get_drvdata(pdev);
332332

333333
disable_irq_wake(ipcc->irq);
334334
irq_domain_remove(ipcc->irq_domain);
335-
336-
return 0;
337335
}
338336

339337
static const struct of_device_id qcom_ipcc_of_match[] = {
@@ -348,7 +346,7 @@ static const struct dev_pm_ops qcom_ipcc_dev_pm_ops = {
348346

349347
static struct platform_driver qcom_ipcc_driver = {
350348
.probe = qcom_ipcc_probe,
351-
.remove = qcom_ipcc_remove,
349+
.remove_new = qcom_ipcc_remove,
352350
.driver = {
353351
.name = "qcom-ipcc",
354352
.of_match_table = qcom_ipcc_of_match,

0 commit comments

Comments
 (0)