Skip to content

Commit d31babd

Browse files
Nicolas Frattarolibroonie
authored andcommitted
ASoC: dapm-graph: set fill colour of turned on nodes
Some tools like KGraphViewer interpret the "ON" nodes not having an explicitly set fill colour as them being entirely black, which obscures the text on them and looks funny. In fact, I thought they were off for the longest time. Comparing to the output of the `dot` tool, I assume they are supposed to be white. Instead of speclawyering over who's in the wrong and must immediately atone for their wickedness at the altar of RFC2119, just be explicit about it, set the fillcolor to white, and nobody gets confused. Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Link: https://patch.msgid.link/20250221-dapm-graph-node-colour-v1-1-514ed0aa7069@collabora.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 0da83ab commit d31babd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/sound/dapm-graph

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ set -eu
1010

1111
STYLE_COMPONENT_ON="color=dodgerblue;style=bold"
1212
STYLE_COMPONENT_OFF="color=gray40;style=filled;fillcolor=gray90"
13-
STYLE_NODE_ON="shape=box,style=bold,color=green4"
13+
STYLE_NODE_ON="shape=box,style=bold,color=green4,fillcolor=white"
1414
STYLE_NODE_OFF="shape=box,style=filled,color=gray30,fillcolor=gray95"
1515

1616
# Print usage and exit

0 commit comments

Comments
 (0)