Skip to content

Commit d27abbf

Browse files
Dan Carpenterthierryreding
authored andcommitted
pwm: Fix double shift bug
These enums are passed to set/test_bit(). The set/test_bit() functions take a bit number instead of a shifted value. Passing a shifted value is a double shift bug like doing BIT(BIT(1)). The double shift bug doesn't cause a problem here because we are only checking 0 and 1 but if the value was 5 or above then it can lead to a buffer overflow. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
1 parent a2da597 commit d27abbf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/linux/pwm.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ struct pwm_args {
4141
};
4242

4343
enum {
44-
PWMF_REQUESTED = 1 << 0,
45-
PWMF_EXPORTED = 1 << 1,
44+
PWMF_REQUESTED = 0,
45+
PWMF_EXPORTED = 1,
4646
};
4747

4848
/*

0 commit comments

Comments
 (0)