Skip to content

Commit d259f13

Browse files
lucaceresolidtor
authored andcommitted
dt-bindings: input: touchscreen: goodix: clarify irq-gpios misleading text
The irq-gpios description misleading, apparently saying that driving the IRQ GPIO resets the device, which is even more puzzling as there is a reset GPIO as well. In reality the IRQ pin can be driven during the reset sequence to configure the client address, as it becomes clear after checking both the datasheet and the driver code. Improve the text to clarify that. Also rephrase to remove reference to the driver, which is not appropriate in the bindings. Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Acked-by: Rob Herring <robh@kernel.org> Reviewed-by: Jeff LaBundy <jeff@labundy.com> Link: https://lore.kernel.org/r/20240102081934.11293-1-luca.ceresoli@bootlin.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 8109e03 commit d259f13

File tree

1 file changed

+3
-2
lines changed
  • Documentation/devicetree/bindings/input/touchscreen

1 file changed

+3
-2
lines changed

Documentation/devicetree/bindings/input/touchscreen/goodix.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ properties:
3737
maxItems: 1
3838

3939
irq-gpios:
40-
description: GPIO pin used for IRQ. The driver uses the interrupt gpio pin
41-
as output to reset the device.
40+
description: GPIO pin used for IRQ input. Additionally, this line is
41+
sampled by the device on reset deassertion to select the I2C client
42+
address, thus it can be driven by the host during the reset sequence.
4243
maxItems: 1
4344

4445
reset-gpios:

0 commit comments

Comments
 (0)