Skip to content

Commit d1f6d6c

Browse files
Danilo Krummrichgregkh
authored andcommitted
rust: pci: use to_result() in enable_device_mem()
Simplify enable_device_mem() by using to_result() to handle the return value of the corresponding FFI call. Reviewed-by: Benno Lossin <benno.lossin@proton.me> Signed-off-by: Danilo Krummrich <dakr@kernel.org> Acked-by: Boqun Feng <boqun.feng@gmail.com> Link: https://lore.kernel.org/r/20250314160932.100165-2-dakr@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent e019684 commit d1f6d6c

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

rust/kernel/pci.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -382,12 +382,7 @@ impl Device {
382382
/// Enable memory resources for this device.
383383
pub fn enable_device_mem(&self) -> Result {
384384
// SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.
385-
let ret = unsafe { bindings::pci_enable_device_mem(self.as_raw()) };
386-
if ret != 0 {
387-
Err(Error::from_errno(ret))
388-
} else {
389-
Ok(())
390-
}
385+
to_result(unsafe { bindings::pci_enable_device_mem(self.as_raw()) })
391386
}
392387

393388
/// Enable bus-mastering for this device.

0 commit comments

Comments
 (0)