Skip to content

Commit d1e8a9f

Browse files
azeemshaikh38martinkpetersen
authored andcommitted
scsi: ncr53c8xx: Replace strlcpy() with strscpy()
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Link: https://lore.kernel.org/r/20230621030033.3800351-2-azeemshaikh38@gmail.com Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 00c2cae commit d1e8a9f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/scsi/ncr53c8xx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4555,7 +4555,7 @@ static void ncr_detach(struct ncb *np)
45554555
char inst_name[16];
45564556

45574557
/* Local copy so we don't access np after freeing it! */
4558-
strlcpy(inst_name, ncr_name(np), sizeof(inst_name));
4558+
strscpy(inst_name, ncr_name(np), sizeof(inst_name));
45594559

45604560
printk("%s: releasing host resources\n", ncr_name(np));
45614561

0 commit comments

Comments
 (0)