Skip to content

Commit d17789e

Browse files
jwrdegoedegregkh
authored andcommitted
staging: rtl8723bs: Pass correct parameters to cfg80211_get_bss()
To last 2 parameters to cfg80211_get_bss() should be of the enum ieee80211_bss_type resp. enum ieee80211_privacy types, which WLAN_CAPABILITY_ESS very much is not. Fix both cfg80211_get_bss() calls in ioctl_cfg80211.c to pass the right parameters. Note that the second call was already somewhat fixed by commenting out WLAN_CAPABILITY_ESS and passing in 0 instead. This was still not entirely correct though since that would limit returned BSS-es to ESS type BSS-es with privacy on. Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230306153512.162104-2-hdegoede@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 05cbcc4 commit d17789e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ int rtw_cfg80211_check_bss(struct adapter *padapter)
350350
bss = cfg80211_get_bss(padapter->rtw_wdev->wiphy, notify_channel,
351351
pnetwork->mac_address, pnetwork->ssid.ssid,
352352
pnetwork->ssid.ssid_length,
353-
WLAN_CAPABILITY_ESS, WLAN_CAPABILITY_ESS);
353+
IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY);
354354

355355
cfg80211_put_bss(padapter->rtw_wdev->wiphy, bss);
356356

@@ -1139,8 +1139,8 @@ void rtw_cfg80211_unlink_bss(struct adapter *padapter, struct wlan_network *pnet
11391139

11401140
bss = cfg80211_get_bss(wiphy, NULL/*notify_channel*/,
11411141
select_network->mac_address, select_network->ssid.ssid,
1142-
select_network->ssid.ssid_length, 0/*WLAN_CAPABILITY_ESS*/,
1143-
0/*WLAN_CAPABILITY_ESS*/);
1142+
select_network->ssid.ssid_length, IEEE80211_BSS_TYPE_ANY,
1143+
IEEE80211_PRIVACY_ANY);
11441144

11451145
if (bss) {
11461146
cfg80211_unlink_bss(wiphy, bss);

0 commit comments

Comments
 (0)