Skip to content

Commit d02fddf

Browse files
robherringbebarino
authored andcommitted
clk: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20230310144701.1541504-1-robh@kernel.org Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent fe15c26 commit d02fddf

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/clk/clk.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4880,8 +4880,8 @@ static struct device_node *get_clk_provider_node(struct device *dev)
48804880
np = dev->of_node;
48814881
parent_np = dev->parent ? dev->parent->of_node : NULL;
48824882

4883-
if (!of_find_property(np, "#clock-cells", NULL))
4884-
if (of_find_property(parent_np, "#clock-cells", NULL))
4883+
if (!of_property_present(np, "#clock-cells"))
4884+
if (of_property_present(parent_np, "#clock-cells"))
48854885
np = parent_np;
48864886

48874887
return np;

drivers/clk/sprd/common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
4444
struct device_node *node = dev->of_node, *np;
4545
struct regmap *regmap;
4646

47-
if (of_find_property(node, "sprd,syscon", NULL)) {
47+
if (of_property_present(node, "sprd,syscon")) {
4848
regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
4949
if (IS_ERR(regmap)) {
5050
pr_err("%s: failed to get syscon regmap\n", __func__);

0 commit comments

Comments
 (0)