Skip to content

Commit cd71090

Browse files
superm1broonie
authored andcommitted
ASoC: amd: ps: Fix extraneous error messages
On Pink Sardine machines that don't have SdW controllers in use, the property `mipi-sdw-manager-list` won't exist. There is no point in showing an error to a user when this situation is encountered. Furthermore if the machine doesn't have a DMIC connected to the ACP, there may be no platform devices created either. Downgrade the associated message to debug. Fixes: d1351c3 ("ASoC: amd: ps: create platform devices based on acp config") Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20230708025208.54272-1-mario.limonciello@amd.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 86867ac commit cd71090

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sound/soc/amd/ps/pci-ps.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ static int sdw_amd_scan_controller(struct device *dev)
257257
&sdw_manager_bitmap, 1);
258258

259259
if (ret) {
260-
dev_err(dev, "Failed to read mipi-sdw-manager-list: %d\n", ret);
260+
dev_dbg(dev, "Failed to read mipi-sdw-manager-list: %d\n", ret);
261261
return -EINVAL;
262262
}
263263
count = hweight32(sdw_manager_bitmap);
@@ -641,7 +641,7 @@ static int snd_acp63_probe(struct pci_dev *pci,
641641
ret = get_acp63_device_config(val, pci, adata);
642642
/* ACP PCI driver probe should be continued even PDM or SoundWire Devices are not found */
643643
if (ret) {
644-
dev_err(&pci->dev, "get acp device config failed:%d\n", ret);
644+
dev_dbg(&pci->dev, "get acp device config failed:%d\n", ret);
645645
goto skip_pdev_creation;
646646
}
647647
ret = create_acp63_platform_devs(pci, adata, addr);

0 commit comments

Comments
 (0)