Skip to content

Commit cd04345

Browse files
dhowellsSteve French
authored andcommitted
cifs: Remove {cifs,nfs}_fscache_release_page()
Remove {cifs,nfs}_fscache_release_page() from fs/cifs/fscache.h. This functionality got built directly into cifs_release_folio() and will hopefully be replaced with netfs_release_folio() at some point. The "nfs_" version is a copy and paste error and should've been altered to read "cifs_". That can also be removed. Reported-by: Matthew Wilcox <willy@infradead.org> Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com> cc: Steve French <smfrench@gmail.com> cc: linux-cifs@vger.kernel.org cc: samba-technical@lists.samba.org cc: linux-fsdevel@vger.kernel.org Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 773891f commit cd04345

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

fs/cifs/fscache.h

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -108,17 +108,6 @@ static inline void cifs_readpage_to_fscache(struct inode *inode,
108108
__cifs_readpage_to_fscache(inode, page);
109109
}
110110

111-
static inline int cifs_fscache_release_page(struct page *page, gfp_t gfp)
112-
{
113-
if (PageFsCache(page)) {
114-
if (current_is_kswapd() || !(gfp & __GFP_FS))
115-
return false;
116-
wait_on_page_fscache(page);
117-
fscache_note_page_release(cifs_inode_cookie(page->mapping->host));
118-
}
119-
return true;
120-
}
121-
122111
#else /* CONFIG_CIFS_FSCACHE */
123112
static inline
124113
void cifs_fscache_fill_coherency(struct inode *inode,
@@ -154,11 +143,6 @@ cifs_readpage_from_fscache(struct inode *inode, struct page *page)
154143
static inline
155144
void cifs_readpage_to_fscache(struct inode *inode, struct page *page) {}
156145

157-
static inline int nfs_fscache_release_page(struct page *page, gfp_t gfp)
158-
{
159-
return true; /* May release page */
160-
}
161-
162146
#endif /* CONFIG_CIFS_FSCACHE */
163147

164148
#endif /* _CIFS_FSCACHE_H */

0 commit comments

Comments
 (0)