Skip to content

Commit ccdb2e0

Browse files
jhnikulaalexandrebelloni
authored andcommitted
i3c: mipi-i3c-hci: Add Intel specific quirk to ring resuming
MIPI I3C HCI on Intel hardware requires a quirk where ring needs to stop and set to run again after resuming the halted controller. This is not expected from the MIPI I3C HCI specification and is Intel specific. Add this quirk to generic aborted transfer handling and execute it only when ring is not in running state after a transfer error and attempted controller resume. This is the case on Intel hardware. It is not fully clear to me what is the ring running state in generic hardware in such case. I would expect if ring is not running, then stop request is a no-op and run request is either required or does the same what controller resume would do. Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Link: https://lore.kernel.org/r/20241231115904.620052-1-jarkko.nikula@linux.intel.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 0d2c022 commit ccdb2e0

File tree

1 file changed

+17
-0
lines changed
  • drivers/i3c/master/mipi-i3c-hci

1 file changed

+17
-0
lines changed

drivers/i3c/master/mipi-i3c-hci/dma.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -758,9 +758,26 @@ static bool hci_dma_irq_handler(struct i3c_hci *hci)
758758
complete(&rh->op_done);
759759

760760
if (status & INTR_TRANSFER_ABORT) {
761+
u32 ring_status;
762+
761763
dev_notice_ratelimited(&hci->master.dev,
762764
"ring %d: Transfer Aborted\n", i);
763765
mipi_i3c_hci_resume(hci);
766+
ring_status = rh_reg_read(RING_STATUS);
767+
if (!(ring_status & RING_STATUS_RUNNING) &&
768+
status & INTR_TRANSFER_COMPLETION &&
769+
status & INTR_TRANSFER_ERR) {
770+
/*
771+
* Ring stop followed by run is an Intel
772+
* specific required quirk after resuming the
773+
* halted controller. Do it only when the ring
774+
* is not in running state after a transfer
775+
* error.
776+
*/
777+
rh_reg_write(RING_CONTROL, RING_CTRL_ENABLE);
778+
rh_reg_write(RING_CONTROL, RING_CTRL_ENABLE |
779+
RING_CTRL_RUN_STOP);
780+
}
764781
}
765782
if (status & INTR_WARN_INS_STOP_MODE)
766783
dev_warn_ratelimited(&hci->master.dev,

0 commit comments

Comments
 (0)