Skip to content

Commit cc349b0

Browse files
dangowrtkuba-moo
authored andcommitted
dt-bindings: net: mediatek: remove wrongly added clocks and SerDes
Several clocks as well as both sgmiisys phandles were added by mistake to the Ethernet bindings for MT7988. Also, the total number of clocks didn't match with the actual number of items listed. This happened because the vendor driver which served as a reference uses a high number of syscon phandles to access various parts of the SoC which wasn't acceptable upstream. Hence several parts which have never previously been supported (such SerDes PHY and USXGMII PCS) are going to be implemented by separate drivers. As a result the device tree will look much more sane. Quickly align the bindings with the upcoming reality of the drivers actually adding support for the remaining Ethernet-related features of the MT7988 SoC. Fixes: c94a9aa ("dt-bindings: net: mediatek,net: add mt7988-eth binding") Signed-off-by: Daniel Golle <daniel@makrotopia.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/1569290b21cc787a424469ed74456a7e976b102d.1715084326.git.daniel@makrotopia.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 0275410 commit cc349b0

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

Documentation/devicetree/bindings/net/mediatek,net.yaml

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -337,8 +337,8 @@ allOf:
337337
minItems: 4
338338

339339
clocks:
340-
minItems: 34
341-
maxItems: 34
340+
minItems: 24
341+
maxItems: 24
342342

343343
clock-names:
344344
items:
@@ -351,18 +351,6 @@ allOf:
351351
- const: ethwarp_wocpu1
352352
- const: ethwarp_wocpu0
353353
- const: esw
354-
- const: netsys0
355-
- const: netsys1
356-
- const: sgmii_tx250m
357-
- const: sgmii_rx250m
358-
- const: sgmii2_tx250m
359-
- const: sgmii2_rx250m
360-
- const: top_usxgmii0_sel
361-
- const: top_usxgmii1_sel
362-
- const: top_sgm0_sel
363-
- const: top_sgm1_sel
364-
- const: top_xfi_phy0_xtal_sel
365-
- const: top_xfi_phy1_xtal_sel
366354
- const: top_eth_gmii_sel
367355
- const: top_eth_refck_50m_sel
368356
- const: top_eth_sys_200m_sel
@@ -375,16 +363,10 @@ allOf:
375363
- const: top_netsys_sync_250m_sel
376364
- const: top_netsys_ppefb_250m_sel
377365
- const: top_netsys_warp_sel
378-
- const: wocpu1
379-
- const: wocpu0
380366
- const: xgp1
381367
- const: xgp2
382368
- const: xgp3
383369

384-
mediatek,sgmiisys:
385-
minItems: 2
386-
maxItems: 2
387-
388370
patternProperties:
389371
"^mac@[0-1]$":
390372
type: object

0 commit comments

Comments
 (0)