Skip to content

Commit cc0e510

Browse files
shinas-marvellkuba-moo
authored andcommitted
octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64
The firmware stats fetch call that happens in ndo_get_stats64() is currently not required, and causes a warning to issue. The corresponding warn log for the PF is given below: [ 123.316837] ------------[ cut here ]------------ [ 123.316840] Voluntary context switch within RCU read-side critical section! [ 123.316917] pc : rcu_note_context_switch+0x2e4/0x300 [ 123.316919] lr : rcu_note_context_switch+0x2e4/0x300 [ 123.316947] Call trace: [ 123.316949] rcu_note_context_switch+0x2e4/0x300 [ 123.316952] __schedule+0x84/0x584 [ 123.316955] schedule+0x38/0x90 [ 123.316956] schedule_timeout+0xa0/0x1d4 [ 123.316959] octep_send_mbox_req+0x190/0x230 [octeon_ep] [ 123.316966] octep_ctrl_net_get_if_stats+0x78/0x100 [octeon_ep] [ 123.316970] octep_get_stats64+0xd4/0xf0 [octeon_ep] [ 123.316975] dev_get_stats+0x4c/0x114 [ 123.316977] dev_seq_printf_stats+0x3c/0x11c [ 123.316980] dev_seq_show+0x1c/0x40 [ 123.316982] seq_read_iter+0x3cc/0x4e0 [ 123.316985] seq_read+0xc8/0x110 [ 123.316987] proc_reg_read+0x9c/0xec [ 123.316990] vfs_read+0xc8/0x2ec [ 123.316993] ksys_read+0x70/0x100 [ 123.316995] __arm64_sys_read+0x20/0x30 [ 123.316997] invoke_syscall.constprop.0+0x7c/0xd0 [ 123.317000] do_el0_svc+0xb4/0xd0 [ 123.317002] el0_svc+0xe8/0x1f4 [ 123.317005] el0t_64_sync_handler+0x134/0x150 [ 123.317006] el0t_64_sync+0x17c/0x180 [ 123.317008] ---[ end trace 63399811432ab69b ]--- Fixes: c3fad23 ("octeon_ep_vf: add support for ndo ops") Signed-off-by: Shinas Rasheed <srasheed@marvell.com> Link: https://patch.msgid.link/20250117094653.2588578-4-srasheed@marvell.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 10fad79 commit cc0e510

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -799,14 +799,6 @@ static void octep_vf_get_stats64(struct net_device *netdev,
799799
stats->tx_bytes = tx_bytes;
800800
stats->rx_packets = rx_packets;
801801
stats->rx_bytes = rx_bytes;
802-
if (!octep_vf_get_if_stats(oct)) {
803-
stats->multicast = oct->iface_rx_stats.mcast_pkts;
804-
stats->rx_errors = oct->iface_rx_stats.err_pkts;
805-
stats->rx_dropped = oct->iface_rx_stats.dropped_pkts_fifo_full +
806-
oct->iface_rx_stats.err_pkts;
807-
stats->rx_missed_errors = oct->iface_rx_stats.dropped_pkts_fifo_full;
808-
stats->tx_dropped = oct->iface_tx_stats.dropped;
809-
}
810802
}
811803

812804
/**

0 commit comments

Comments
 (0)