Skip to content

Commit cb2bffd

Browse files
Uwe Kleine-Königtiwai
authored andcommitted
ALSA: pcmtest: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Ivan Orlov <ivan.orlov0322@gmail.com> Link: https://lore.kernel.org/r/20230707075058.3402832-1-u.kleine-koenig@pengutronix.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 06c2afb commit cb2bffd

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

sound/drivers/pcmtest.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -576,10 +576,9 @@ static int pcmtst_probe(struct platform_device *pdev)
576576
return 0;
577577
}
578578

579-
static int pdev_remove(struct platform_device *dev)
579+
static void pdev_remove(struct platform_device *dev)
580580
{
581581
snd_pcmtst_free(pcmtst);
582-
return 0;
583582
}
584583

585584
static struct platform_device pcmtst_pdev = {
@@ -589,7 +588,7 @@ static struct platform_device pcmtst_pdev = {
589588

590589
static struct platform_driver pcmtst_pdrv = {
591590
.probe = pcmtst_probe,
592-
.remove = pdev_remove,
591+
.remove_new = pdev_remove,
593592
.driver = {
594593
.name = "pcmtest",
595594
},

0 commit comments

Comments
 (0)