Skip to content

Commit caa2898

Browse files
committed
linux/types.h: reinstate "__bitwise__" macro for user space use
Commit c724c86 ("linux/types.h: remove unnecessary __bitwise__") was right that there are no users of __bitwise__ in the kernel, but it turns out there are user space users of it that do expect it. It is, after all, in the uapi directory, so user space usage is to be expected. Instead of reverting the commit completely, let's just clarify the situation so that it doesn't happen again, and have some in-code explanations for why that "__bitwise__" still exists. Reported-by: Jiri Slaby <jirislaby@kernel.org> Cc: Bjorn Helgaas <helgaas@kernel.org> Link: https://lore.kernel.org/all/b5c0a68d-8387-4909-beea-f70ab9e6e3d5@kernel.org/ Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent e5499dd commit caa2898

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

include/uapi/linux/types.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
#define __bitwise
2727
#endif
2828

29+
/* The kernel doesn't use this legacy form, but user space does */
30+
#define __bitwise__ __bitwise
31+
2932
typedef __u16 __bitwise __le16;
3033
typedef __u16 __bitwise __be16;
3134
typedef __u32 __bitwise __le32;

0 commit comments

Comments
 (0)