Skip to content

Commit c9bd265

Browse files
author
Florian Westphal
committed
netfilter: nf_tables: disable toggling dormant table state more than once
nft -f -<<EOF add table ip t add table ip t { flags dormant; } add chain ip t c { type filter hook input priority 0; } add table ip t EOF Triggers a splat from nf core on next table delete because we lose track of right hook register state: WARNING: CPU: 2 PID: 1597 at net/netfilter/core.c:501 __nf_unregister_net_hook RIP: 0010:__nf_unregister_net_hook+0x41b/0x570 nf_unregister_net_hook+0xb4/0xf0 __nf_tables_unregister_hook+0x160/0x1d0 [..] The above should have table in *active* state, but in fact no hooks were registered. Reject on/off/on games rather than attempting to fix this. Fixes: 179d9ba ("netfilter: nf_tables: fix table flag updates") Reported-by: "Lee, Cherie-Anne" <cherie.lee@starlabs.sg> Cc: Bing-Jhong Billy Jheng <billy@starlabs.sg> Cc: info@starlabs.sg Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent 4e4b179 commit c9bd265

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

net/netfilter/nf_tables_api.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1219,6 +1219,10 @@ static int nf_tables_updtable(struct nft_ctx *ctx)
12191219
flags & NFT_TABLE_F_OWNER))
12201220
return -EOPNOTSUPP;
12211221

1222+
/* No dormant off/on/off/on games in single transaction */
1223+
if (ctx->table->flags & __NFT_TABLE_F_UPDATE)
1224+
return -EINVAL;
1225+
12221226
trans = nft_trans_alloc(ctx, NFT_MSG_NEWTABLE,
12231227
sizeof(struct nft_trans_table));
12241228
if (trans == NULL)

0 commit comments

Comments
 (0)