Skip to content

Commit c99e1e1

Browse files
arndbgregkh
authored andcommitted
vbox: add HAS_IOPORT dependency
The vboxguest driver depends on port I/O for debug output: include/asm-generic/io.h:626:15: error: call to '_outl' declared with attribute error: outl() requires CONFIG_HAS_IOPORT 626 | #define _outl _outl include/asm-generic/io.h:663:14: note: in expansion of macro '_outl' 663 | #define outl _outl | ^~~~~ drivers/virt/vboxguest/vboxguest_utils.c:102:9: note: in expansion of macro 'outl' 102 | outl(phys_req, gdev->io_port + VMMDEV_PORT_OFF_REQUEST); | ^~~~ Most arm64 platforms don't actually support port I/O, though it is currently enabled unconditionally. Refine the vbox dependency to allow turning HAS_IOPORT off in the future when building for platforms without port I/O and allow compile-testing on all architectures. Fixes: 5cf8f93 ("vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20250122065445.1469218-1-arnd@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 91d44c1 commit c99e1e1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/virt/vboxguest/Kconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22
config VBOXGUEST
33
tristate "Virtual Box Guest integration support"
4-
depends on (ARM64 || X86) && PCI && INPUT
4+
depends on (ARM64 || X86 || COMPILE_TEST) && PCI && INPUT
5+
depends on HAS_IOPORT
56
help
67
This is a driver for the Virtual Box Guest PCI device used in
78
Virtual Box virtual machines. Enabling this driver will add

0 commit comments

Comments
 (0)