Skip to content

Commit c98b104

Browse files
committed
drm/v3d: Enable Performance Counters before clearing them
On the Raspberry Pi 5, performance counters are not being cleared when `v3d_perfmon_start()` is called, even though we write to the CLR register. As a result, their values accumulate until they overflow. The expected behavior is for performance counters to reset to zero at the start of a job. When the job finishes and the perfmon is stopped, the counters should accurately reflect the values for that specific job. To ensure this behavior, the performance counters are now enabled before being cleared. This allows the CLR register to function as intended, zeroing the counter values when the job begins. Fixes: 26a4dc2 ("drm/v3d: Expose performance counters to userspace") Signed-off-by: Maíra Canal <mcanal@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241204122831.17015-1-mcanal@igalia.com
1 parent 59ca0e1 commit c98b104

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/v3d/v3d_perfmon.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,9 @@ void v3d_perfmon_start(struct v3d_dev *v3d, struct v3d_perfmon *perfmon)
254254
V3D_CORE_WRITE(0, V3D_V4_PCTR_0_SRC_X(source), channel);
255255
}
256256

257+
V3D_CORE_WRITE(0, V3D_V4_PCTR_0_EN, mask);
257258
V3D_CORE_WRITE(0, V3D_V4_PCTR_0_CLR, mask);
258259
V3D_CORE_WRITE(0, V3D_PCTR_0_OVERFLOW, mask);
259-
V3D_CORE_WRITE(0, V3D_V4_PCTR_0_EN, mask);
260260

261261
v3d->active_perfmon = perfmon;
262262
}

0 commit comments

Comments
 (0)