Skip to content

Commit c90e3ec

Browse files
Onkarnathfbq
authored andcommitted
rcu/sync: remove un-used rcu_sync_enter_start function
With commit '6a010a49b63a ("cgroup: Make !percpu threadgroup_rwsem operations optional")' usage of rcu_sync_enter_start is removed. So this function can also be removed. In the words of Oleg Nesterov: __rcu_sync_enter(wait => false) is a better alternative if someone needs rcu_sync_enter_start() again. Link: https://lore.kernel.org/all/20220725121208.GB28662@redhat.com/ Signed-off-by: Onkarnath <onkarnath.1@samsung.com> Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Tejun Heo <tj@kernel.org> Reviewed-by: Paul E. McKenney <paulmck@kernel.org> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
1 parent fd2a749 commit c90e3ec

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

include/linux/rcu_sync.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ static inline bool rcu_sync_is_idle(struct rcu_sync *rsp)
3737
}
3838

3939
extern void rcu_sync_init(struct rcu_sync *);
40-
extern void rcu_sync_enter_start(struct rcu_sync *);
4140
extern void rcu_sync_enter(struct rcu_sync *);
4241
extern void rcu_sync_exit(struct rcu_sync *);
4342
extern void rcu_sync_dtor(struct rcu_sync *);

kernel/rcu/sync.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,6 @@ void rcu_sync_init(struct rcu_sync *rsp)
2424
init_waitqueue_head(&rsp->gp_wait);
2525
}
2626

27-
/**
28-
* rcu_sync_enter_start - Force readers onto slow path for multiple updates
29-
* @rsp: Pointer to rcu_sync structure to use for synchronization
30-
*
31-
* Must be called after rcu_sync_init() and before first use.
32-
*
33-
* Ensures rcu_sync_is_idle() returns false and rcu_sync_{enter,exit}()
34-
* pairs turn into NO-OPs.
35-
*/
36-
void rcu_sync_enter_start(struct rcu_sync *rsp)
37-
{
38-
rsp->gp_count++;
39-
rsp->gp_state = GP_PASSED;
40-
}
41-
42-
4327
static void rcu_sync_func(struct rcu_head *rhp);
4428

4529
static void rcu_sync_call(struct rcu_sync *rsp)

0 commit comments

Comments
 (0)