Skip to content

Commit c8e88de

Browse files
djbwdavejiang
authored andcommitted
ACPI/HMAT: Move HMAT messages to pr_debug()
The HMAT messages printed at boot, beyond being noisy, can also print details for nodes that are not yet enabled. The primary method to consume HMAT details is via sysfs, and the sysfs interface gates what is emitted by whether the node is online or not. Hide the messages by default by moving them from "info" to "debug" log level. Otherwise, these prints are just a pretty-print way to dump the ACPI HMAT table. It has always been the case that post-analysis was required for these messages to map proximity-domains to Linux NUMA nodes, and as Priya points out that analysis also needs to consider whether the proximity domain is marked "enabled" in the SRAT. Reported-by: Priya Autee <priya.v.autee@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/170668982094.318782.2963631284830500182.stgit@dwillia2-xfh.jf.intel.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent fc033cf commit c8e88de

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

drivers/acpi/numa/hmat.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -442,9 +442,9 @@ static __init int hmat_parse_locality(union acpi_subtable_headers *header,
442442
return -EINVAL;
443443
}
444444

445-
pr_info("Locality: Flags:%02x Type:%s Initiator Domains:%u Target Domains:%u Base:%lld\n",
446-
hmat_loc->flags, hmat_data_type(type), ipds, tpds,
447-
hmat_loc->entry_base_unit);
445+
pr_debug("Locality: Flags:%02x Type:%s Initiator Domains:%u Target Domains:%u Base:%lld\n",
446+
hmat_loc->flags, hmat_data_type(type), ipds, tpds,
447+
hmat_loc->entry_base_unit);
448448

449449
inits = (u32 *)(hmat_loc + 1);
450450
targs = inits + ipds;
@@ -455,9 +455,9 @@ static __init int hmat_parse_locality(union acpi_subtable_headers *header,
455455
value = hmat_normalize(entries[init * tpds + targ],
456456
hmat_loc->entry_base_unit,
457457
type);
458-
pr_info(" Initiator-Target[%u-%u]:%u%s\n",
459-
inits[init], targs[targ], value,
460-
hmat_data_type_suffix(type));
458+
pr_debug(" Initiator-Target[%u-%u]:%u%s\n",
459+
inits[init], targs[targ], value,
460+
hmat_data_type_suffix(type));
461461

462462
hmat_update_target(targs[targ], inits[init],
463463
mem_hier, type, value);
@@ -485,9 +485,9 @@ static __init int hmat_parse_cache(union acpi_subtable_headers *header,
485485
}
486486

487487
attrs = cache->cache_attributes;
488-
pr_info("Cache: Domain:%u Size:%llu Attrs:%08x SMBIOS Handles:%d\n",
489-
cache->memory_PD, cache->cache_size, attrs,
490-
cache->number_of_SMBIOShandles);
488+
pr_debug("Cache: Domain:%u Size:%llu Attrs:%08x SMBIOS Handles:%d\n",
489+
cache->memory_PD, cache->cache_size, attrs,
490+
cache->number_of_SMBIOShandles);
491491

492492
target = find_mem_target(cache->memory_PD);
493493
if (!target)
@@ -546,9 +546,9 @@ static int __init hmat_parse_proximity_domain(union acpi_subtable_headers *heade
546546
}
547547

548548
if (hmat_revision == 1)
549-
pr_info("Memory (%#llx length %#llx) Flags:%04x Processor Domain:%u Memory Domain:%u\n",
550-
p->reserved3, p->reserved4, p->flags, p->processor_PD,
551-
p->memory_PD);
549+
pr_debug("Memory (%#llx length %#llx) Flags:%04x Processor Domain:%u Memory Domain:%u\n",
550+
p->reserved3, p->reserved4, p->flags, p->processor_PD,
551+
p->memory_PD);
552552
else
553553
pr_info("Memory Flags:%04x Processor Domain:%u Memory Domain:%u\n",
554554
p->flags, p->processor_PD, p->memory_PD);

0 commit comments

Comments
 (0)