Skip to content

Commit c8d81a4

Browse files
Salomon Dushimirimanamartinkpetersen
authored andcommitted
scsi: pm8001: Use module param to set pcs event log severity
The pm8001 driver sets pcs event log threshold very high which causes most of the FW log messages to not be captured. Add a module parameter to configure pcs event log severity with 3 (medium severity) as the default. Co-developed-by: Bhavesh Jashnani <bjashnani@google.com> Signed-off-by: Bhavesh Jashnani <bjashnani@google.com> Signed-off-by: Salomon Dushimirimana <salomondush@google.com> Link: https://lore.kernel.org/r/20241016220944.370539-1-salomondush@google.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 7670e74 commit c8d81a4

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

drivers/scsi/pm8001/pm8001_init.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ static bool pm8001_read_wwn = true;
6868
module_param_named(read_wwn, pm8001_read_wwn, bool, 0444);
6969
MODULE_PARM_DESC(zoned, "Get WWN from the controller. Default: true");
7070

71+
uint pcs_event_log_severity = 0x03;
72+
module_param(pcs_event_log_severity, int, 0644);
73+
MODULE_PARM_DESC(pcs_event_log_severity, "PCS event log severity level");
74+
7175
static struct scsi_transport_template *pm8001_stt;
7276
static int pm8001_init_ccb_tag(struct pm8001_hba_info *);
7377

drivers/scsi/pm8001/pm8001_sas.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ extern struct list_head hba_list;
9696
extern const struct pm8001_dispatch pm8001_8001_dispatch;
9797
extern const struct pm8001_dispatch pm8001_80xx_dispatch;
9898

99+
extern uint pcs_event_log_severity;
100+
99101
struct pm8001_hba_info;
100102
struct pm8001_ccb_info;
101103
struct pm8001_device;

drivers/scsi/pm8001/pm80xx_hwi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,8 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
763763
pm8001_ha->memoryMap.region[IOP].phys_addr_lo;
764764
pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_size =
765765
PM8001_EVENT_LOG_SIZE;
766-
pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity = 0x01;
766+
pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity =
767+
pcs_event_log_severity;
767768
pm8001_ha->main_cfg_tbl.pm80xx_tbl.fatal_err_interrupt = 0x01;
768769

769770
/* Enable higher IQs and OQs, 32 to 63, bit 16 */

0 commit comments

Comments
 (0)