Skip to content

Commit c8bb21b

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: ti: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-28-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 3fd43a2 commit c8bb21b

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/clk/ti/adpll.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -931,13 +931,11 @@ static int ti_adpll_probe(struct platform_device *pdev)
931931
return err;
932932
}
933933

934-
static int ti_adpll_remove(struct platform_device *pdev)
934+
static void ti_adpll_remove(struct platform_device *pdev)
935935
{
936936
struct ti_adpll_data *d = dev_get_drvdata(&pdev->dev);
937937

938938
ti_adpll_free_resources(d);
939-
940-
return 0;
941939
}
942940

943941
static struct platform_driver ti_adpll_driver = {
@@ -946,7 +944,7 @@ static struct platform_driver ti_adpll_driver = {
946944
.of_match_table = ti_adpll_match,
947945
},
948946
.probe = ti_adpll_probe,
949-
.remove = ti_adpll_remove,
947+
.remove_new = ti_adpll_remove,
950948
};
951949

952950
static int __init ti_adpll_init(void)

0 commit comments

Comments
 (0)