Skip to content

Commit c6f7874

Browse files
ribaldabroonie
authored andcommitted
spi: mediatek: Enable irq when pdata is ready
If the device does not come straight from reset, we might receive an IRQ before we are ready to handle it. Fixes: [ 0.832328] Unable to handle kernel read from unreadable memory at virtual address 0000000000000010 [ 1.040343] Call trace: [ 1.040347] mtk_spi_can_dma+0xc/0x40 ... [ 1.262265] start_kernel+0x338/0x42c Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20221128-spi-mt65xx-v1-0-509266830665@chromium.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 63d9a4d commit c6f7874

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

drivers/spi/spi-mt65xx.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,11 +1189,6 @@ static int mtk_spi_probe(struct platform_device *pdev)
11891189
else
11901190
dma_set_max_seg_size(dev, SZ_256K);
11911191

1192-
ret = devm_request_irq(dev, irq, mtk_spi_interrupt,
1193-
IRQF_TRIGGER_NONE, dev_name(dev), master);
1194-
if (ret)
1195-
return dev_err_probe(dev, ret, "failed to register irq\n");
1196-
11971192
mdata->parent_clk = devm_clk_get(dev, "parent-clk");
11981193
if (IS_ERR(mdata->parent_clk))
11991194
return dev_err_probe(dev, PTR_ERR(mdata->parent_clk),
@@ -1263,6 +1258,13 @@ static int mtk_spi_probe(struct platform_device *pdev)
12631258
return dev_err_probe(dev, ret, "failed to register master\n");
12641259
}
12651260

1261+
ret = devm_request_irq(dev, irq, mtk_spi_interrupt,
1262+
IRQF_TRIGGER_NONE, dev_name(dev), master);
1263+
if (ret) {
1264+
pm_runtime_disable(dev);
1265+
return dev_err_probe(dev, ret, "failed to register irq\n");
1266+
}
1267+
12661268
return 0;
12671269
}
12681270

0 commit comments

Comments
 (0)