Skip to content

Commit c69c5e1

Browse files
leitaokuba-moo
authored andcommitted
netpoll: Use rcu_access_pointer() in __netpoll_setup
The ndev->npinfo pointer in __netpoll_setup() is RCU-protected but is being accessed directly for a NULL check. While no RCU read lock is held in this context, we should still use proper RCU primitives for consistency and correctness. Replace the direct NULL check with rcu_access_pointer(), which is the appropriate primitive when only checking for NULL without dereferencing the pointer. This function provides the necessary ordering guarantees without requiring RCU read-side protection. Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> Signed-off-by: Breno Leitao <leitao@debian.org> Link: https://patch.msgid.link/20241118-netpoll_rcu-v1-1-a1888dcb4a02@debian.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 4262bac commit c69c5e1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/core/netpoll.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,7 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev)
626626
goto out;
627627
}
628628

629-
if (!ndev->npinfo) {
629+
if (!rcu_access_pointer(ndev->npinfo)) {
630630
npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL);
631631
if (!npinfo) {
632632
err = -ENOMEM;

0 commit comments

Comments
 (0)