Skip to content

Commit c55afcb

Browse files
Guiting Shengregkh
authored andcommitted
usb: ohci-at91: Fix the unhandle interrupt when resume
The ohci_hcd_at91_drv_suspend() sets ohci->rh_state to OHCI_RH_HALTED when suspend which will let the ohci_irq() skip the interrupt after resume. And nobody to handle this interrupt. According to the comment in ohci_hcd_at91_drv_suspend(), it need to reset when resume from suspend(MEM) to fix by setting "hibernated" argument of ohci_resume(). Signed-off-by: Guiting Shen <aarongt.shen@gmail.com> Cc: stable <stable@kernel.org> Reviewed-by: Alan Stern <stern@rowland.harvard.edu> Link: https://lore.kernel.org/r/20230626152713.18950-1-aarongt.shen@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 13e098b commit c55afcb

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

drivers/usb/host/ohci-at91.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,13 @@ ohci_hcd_at91_drv_resume(struct device *dev)
672672
else
673673
at91_start_clock(ohci_at91);
674674

675-
ohci_resume(hcd, false);
675+
/*
676+
* According to the comment in ohci_hcd_at91_drv_suspend()
677+
* we need to do a reset if the 48Mhz clock was stopped,
678+
* that is, if ohci_at91->wakeup is clear. Tell ohci_resume()
679+
* to reset in this case by setting its "hibernated" flag.
680+
*/
681+
ohci_resume(hcd, !ohci_at91->wakeup);
676682

677683
return 0;
678684
}

0 commit comments

Comments
 (0)