Skip to content

Commit c53b3dc

Browse files
committed
Merge tag 'staging-6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
Pull staging driver fixes from Greg KH: "Here are three small staging driver fixes for 6.0-rc4 that resolve some reported problems and add some a device id: - new device id for r8188eu driver - use-after-free bugfixes for the rtl8712 driver - fix up firmware dependency problem for the r8188eu driver All of these have been in linux-next for a while with no reported problems" * tag 'staging-6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: staging: rtl8712: fix use after free bugs staging: r8188eu: Add Rosewill USB-N150 Nano to device tables staging: r8188eu: add firmware dependency
2 parents 9a61442 + e230a44 commit c53b3dc

File tree

3 files changed

+2
-36
lines changed

3 files changed

+2
-36
lines changed

drivers/staging/r8188eu/os_dep/os_intfs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ MODULE_LICENSE("GPL");
1818
MODULE_DESCRIPTION("Realtek Wireless Lan Driver");
1919
MODULE_AUTHOR("Realtek Semiconductor Corp.");
2020
MODULE_VERSION(DRIVERVERSION);
21+
MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin");
2122

2223
#define CONFIG_BR_EXT_BRNAME "br0"
2324
#define RTW_NOTCH_FILTER 0 /* 0:Disable, 1:Enable, */

drivers/staging/r8188eu/os_dep/usb_intf.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
2828
/*=== Realtek demoboard ===*/
2929
{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8179)}, /* 8188EUS */
3030
{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
31+
{USB_DEVICE(USB_VENDER_ID_REALTEK, 0xffef)}, /* Rosewill USB-N150 Nano */
3132
/*=== Customer ID ===*/
3233
/****** 8188EUS ********/
3334
{USB_DEVICE(0x07B8, 0x8179)}, /* Abocom - Abocom */

drivers/staging/rtl8712/rtl8712_cmd.c

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -117,34 +117,6 @@ static void r871x_internal_cmd_hdl(struct _adapter *padapter, u8 *pbuf)
117117
kfree(pdrvcmd->pbuf);
118118
}
119119

120-
static u8 read_macreg_hdl(struct _adapter *padapter, u8 *pbuf)
121-
{
122-
void (*pcmd_callback)(struct _adapter *dev, struct cmd_obj *pcmd);
123-
struct cmd_obj *pcmd = (struct cmd_obj *)pbuf;
124-
125-
/* invoke cmd->callback function */
126-
pcmd_callback = cmd_callback[pcmd->cmdcode].callback;
127-
if (!pcmd_callback)
128-
r8712_free_cmd_obj(pcmd);
129-
else
130-
pcmd_callback(padapter, pcmd);
131-
return H2C_SUCCESS;
132-
}
133-
134-
static u8 write_macreg_hdl(struct _adapter *padapter, u8 *pbuf)
135-
{
136-
void (*pcmd_callback)(struct _adapter *dev, struct cmd_obj *pcmd);
137-
struct cmd_obj *pcmd = (struct cmd_obj *)pbuf;
138-
139-
/* invoke cmd->callback function */
140-
pcmd_callback = cmd_callback[pcmd->cmdcode].callback;
141-
if (!pcmd_callback)
142-
r8712_free_cmd_obj(pcmd);
143-
else
144-
pcmd_callback(padapter, pcmd);
145-
return H2C_SUCCESS;
146-
}
147-
148120
static u8 read_bbreg_hdl(struct _adapter *padapter, u8 *pbuf)
149121
{
150122
struct cmd_obj *pcmd = (struct cmd_obj *)pbuf;
@@ -213,14 +185,6 @@ static struct cmd_obj *cmd_hdl_filter(struct _adapter *padapter,
213185
pcmd_r = NULL;
214186

215187
switch (pcmd->cmdcode) {
216-
case GEN_CMD_CODE(_Read_MACREG):
217-
read_macreg_hdl(padapter, (u8 *)pcmd);
218-
pcmd_r = pcmd;
219-
break;
220-
case GEN_CMD_CODE(_Write_MACREG):
221-
write_macreg_hdl(padapter, (u8 *)pcmd);
222-
pcmd_r = pcmd;
223-
break;
224188
case GEN_CMD_CODE(_Read_BBREG):
225189
read_bbreg_hdl(padapter, (u8 *)pcmd);
226190
break;

0 commit comments

Comments
 (0)