Skip to content

Commit c4a123d

Browse files
committed
pNFS: Fix assignment of xprtdata.cred
The comma at the end of the line was leftover from an earlier refactor of the _nfs4_pnfs_v3_ds_connect() function. This is technically valid C, so the compilers didn't catch it, but if I'm understanding how it works correctly it assigns the return value of rpc_clnt_add_xprtr() to xprtdata.cred. Reported-by: Olga Kornievskaia <kolga@netapp.com> Fixes: a12f996 ("NFSv4/pNFS: Use connections to a DS that are all of the same protocol family") Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
1 parent 5690eed commit c4a123d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/nfs/pnfs_nfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -946,7 +946,7 @@ static int _nfs4_pnfs_v4_ds_connect(struct nfs_server *mds_srv,
946946
* Test this address for session trunking and
947947
* add as an alias
948948
*/
949-
xprtdata.cred = nfs4_get_clid_cred(clp),
949+
xprtdata.cred = nfs4_get_clid_cred(clp);
950950
rpc_clnt_add_xprt(clp->cl_rpcclient, &xprt_args,
951951
rpc_clnt_setup_test_and_add_xprt,
952952
&rpcdata);

0 commit comments

Comments
 (0)