Skip to content

Commit c3e6df9

Browse files
committed
Revert "perf build: Warn for BPF skeletons if endian mismatches"
This reverts commit 51924ae. We need to better polish building with BPF skels, so revert back to making it an experimental feature that has to be explicitely enabled using BUILD_BPF_SKEL=1. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 6c73f81 commit c3e6df9

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

tools/perf/Makefile.config

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -663,17 +663,14 @@ ifndef NO_BPF_SKEL
663663
$(call feature_check,clang-bpf-co-re)
664664
ifeq ($(feature-clang-bpf-co-re), 0)
665665
dummy := $(error: ERROR: BPF skeletons unsupported. clang too old/not installed or build with NO_BPF_SKEL=1.)
666+
else
667+
ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),)
668+
dummy := $(error: ERROR: BPF skeletons unsupported. BPF skeleton support requires libbpf or build with NO_BPF_SKEL=1.)
669+
else
670+
$(call detected,CONFIG_PERF_BPF_SKEL)
671+
CFLAGS += -DHAVE_BPF_SKEL
672+
endif
666673
endif
667-
ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),)
668-
dummy := $(error: ERROR: BPF skeletons unsupported. BPF skeleton support requires libbpf or build with NO_BPF_SKEL=1.)
669-
endif
670-
host_byte_order=$(echo ""|$(HOSTCC) -dM -E -|grep __BYTE_ORDER__)
671-
target_byte_order=$(echo ""|$(CC) -dM -E -|grep __BYTE_ORDER__)
672-
ifneq ($(host_byte_order), $(target_byte_order))
673-
$(warning Possibly mismatched host and target endianness may break BPF skeletons)
674-
endif
675-
$(call detected,CONFIG_PERF_BPF_SKEL)
676-
CFLAGS += -DHAVE_BPF_SKEL
677674
endif
678675

679676
dwarf-post-unwind := 1

0 commit comments

Comments
 (0)