Skip to content

Commit c271c86

Browse files
xry111chenhuacai
authored andcommitted
LoongArch: vDSO: Remove --hash-style=sysv
Glibc added support for .gnu.hash in 2006 and .hash has been obsoleted far before the first LoongArch CPU was taped. Using --hash-style=sysv might imply unaddressed issues and confuse readers. Some architectures use an explicit --hash-style=both for vDSO here, but DT_GNU_HASH has already been supported by Glibc and Musl and become the de-facto standard of the distros when the first LoongArch CPU was taped. So DT_HASH seems just wasting storage space for LoongArch. Just drop the option and rely on the linker default, which is likely "gnu" (Arch, Debian, Gentoo, LFS) on all LoongArch distros (confirmed on Arch, Debian, Gentoo, and LFS; AOSC now defaults to "both" but it seems just an oversight). Following the logic of commit 48f6430 ("arm64/vdso: Remove --hash-style=sysv"). Link: AOSC-Dev/aosc-os-abbs#9796 Signed-off-by: Xi Ruoyao <xry111@xry111.site> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent 60f3caf commit c271c86

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

arch/loongarch/vdso/Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ endif
3636

3737
# VDSO linker flags.
3838
ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
39-
$(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \
40-
--hash-style=sysv --build-id -T
39+
$(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared --build-id -T
4140

4241
#
4342
# Shared build commands.

0 commit comments

Comments
 (0)