Skip to content

Commit c16af12

Browse files
Wang KefengRussell King (Oracle)
authored andcommitted
ARM: 9328/1: mm: try VMA lock-based page fault handling first
Attempt VMA lock-based page fault handling first, and fall back to the existing mmap_lock-based handling if that fails, the ebizzy benchmark shows 25% improvement on qemu with 2 cpus. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
1 parent b85ea95 commit c16af12

File tree

2 files changed

+31
-0
lines changed

2 files changed

+31
-0
lines changed

arch/arm/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ config ARM
3535
select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if CPU_V7
3636
select ARCH_SUPPORTS_ATOMIC_RMW
3737
select ARCH_SUPPORTS_HUGETLBFS if ARM_LPAE
38+
select ARCH_SUPPORTS_PER_VMA_LOCK
3839
select ARCH_USE_BUILTIN_BSWAP
3940
select ARCH_USE_CMPXCHG_LOCKREF
4041
select ARCH_USE_MEMTEST

arch/arm/mm/fault.c

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,35 @@ do_page_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
278278

279279
perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, addr);
280280

281+
if (!(flags & FAULT_FLAG_USER))
282+
goto lock_mmap;
283+
284+
vma = lock_vma_under_rcu(mm, addr);
285+
if (!vma)
286+
goto lock_mmap;
287+
288+
if (!(vma->vm_flags & vm_flags)) {
289+
vma_end_read(vma);
290+
goto lock_mmap;
291+
}
292+
fault = handle_mm_fault(vma, addr, flags | FAULT_FLAG_VMA_LOCK, regs);
293+
if (!(fault & (VM_FAULT_RETRY | VM_FAULT_COMPLETED)))
294+
vma_end_read(vma);
295+
296+
if (!(fault & VM_FAULT_RETRY)) {
297+
count_vm_vma_lock_event(VMA_LOCK_SUCCESS);
298+
goto done;
299+
}
300+
count_vm_vma_lock_event(VMA_LOCK_RETRY);
301+
302+
/* Quick path to respond to signals */
303+
if (fault_signal_pending(fault, regs)) {
304+
if (!user_mode(regs))
305+
goto no_context;
306+
return 0;
307+
}
308+
lock_mmap:
309+
281310
retry:
282311
vma = lock_mm_and_find_vma(mm, addr, regs);
283312
if (unlikely(!vma)) {
@@ -316,6 +345,7 @@ do_page_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
316345
}
317346

318347
mmap_read_unlock(mm);
348+
done:
319349

320350
/*
321351
* Handle the "normal" case first - VM_FAULT_MAJOR

0 commit comments

Comments
 (0)