Skip to content

Commit bffa721

Browse files
Yang Yingliangvinodkoul
authored andcommitted
dmaengine: fsl-edma: fix wrong pointer check in fsl_edma3_attach_pd()
device_link_add() returns NULL pointer not PTR_ERR() when it fails, so replace the IS_ERR() check with NULL pointer check. Fixes: 72f5801 ("dmaengine: fsl-edma: integrate v3 support") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20231129090000.841440-1-yangyingliang@huaweicloud.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 0c15469 commit bffa721

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/dma/fsl-edma-main.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,9 +396,8 @@ static int fsl_edma3_attach_pd(struct platform_device *pdev, struct fsl_edma_eng
396396
link = device_link_add(dev, pd_chan, DL_FLAG_STATELESS |
397397
DL_FLAG_PM_RUNTIME |
398398
DL_FLAG_RPM_ACTIVE);
399-
if (IS_ERR(link)) {
400-
dev_err(dev, "Failed to add device_link to %d: %ld\n", i,
401-
PTR_ERR(link));
399+
if (!link) {
400+
dev_err(dev, "Failed to add device_link to %d\n", i);
402401
return -EINVAL;
403402
}
404403

0 commit comments

Comments
 (0)