Skip to content

Commit bf79175

Browse files
committed
thunderbolt: Add only on-board retimers when !CONFIG_USB4_DEBUGFS_MARGINING
Normally there is no need to enumerate retimers on the other side of the cable. This is only needed in special cases where user wants to run receiver lane margining against the downstream facing port of a retimer. Furthermore this might confuse the userspace tools such as fwupd because it cannot read the information it expects from these retimers. Fix this by changing the retimer enumeration code to add only on-board retimers when CONFIG_USB4_DEBUGFS_MARGINING is not enabled. Reported-by: AceLan Kao <acelan.kao@canonical.com> Tested-by: AceLan Kao <acelan.kao@canonical.com> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219420 Cc: stable@vger.kernel.org Fixes: ff6ab05 ("thunderbolt: Add receiver lane margining support for retimers") Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
1 parent 8198375 commit bf79175

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/thunderbolt/retimer.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,8 @@ int tb_retimer_scan(struct tb_port *port, bool add)
531531

532532
max = i;
533533
ret = 0;
534+
if (!IS_ENABLED(CONFIG_USB4_DEBUGFS_MARGINING))
535+
max = min(last_idx, max);
534536

535537
/* Add retimers if they do not exist already */
536538
for (i = 1; i <= max; i++) {

0 commit comments

Comments
 (0)