Skip to content

Commit be8d1a2

Browse files
Yang Likdave
authored andcommitted
btrfs: fix argument list that the kdoc format and script verified
The warnings were found by running scripts/kernel-doc, which is caused by using 'make W=1'. fs/btrfs/extent_io.c:3210: warning: Function parameter or member 'bio_ctrl' not described in 'btrfs_bio_add_page' fs/btrfs/extent_io.c:3210: warning: Excess function parameter 'bio' description in 'btrfs_bio_add_page' fs/btrfs/extent_io.c:3210: warning: Excess function parameter 'prev_bio_flags' description in 'btrfs_bio_add_page' fs/btrfs/space-info.c:1602: warning: Excess function parameter 'root' description in 'btrfs_reserve_metadata_bytes' fs/btrfs/space-info.c:1602: warning: Function parameter or member 'fs_info' not described in 'btrfs_reserve_metadata_bytes' Note: this is fixing only the warnings regarding parameter list, the first line is not strictly conforming to the kdoc format as the btrfs codebase does not stick to that and keeps the first line more free form (because it's only for internal use). Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: David Sterba <dsterba@suse.com> [ add note ] Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 4a9e803 commit be8d1a2

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

fs/btrfs/extent_io.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3184,13 +3184,12 @@ struct bio *btrfs_bio_clone_partial(struct bio *orig, u64 offset, u64 size)
31843184
/**
31853185
* Attempt to add a page to bio
31863186
*
3187-
* @bio: destination bio
3187+
* @bio_ctrl: record both the bio, and its bio_flags
31883188
* @page: page to add to the bio
31893189
* @disk_bytenr: offset of the new bio or to check whether we are adding
31903190
* a contiguous page to the previous one
3191-
* @pg_offset: starting offset in the page
31923191
* @size: portion of page that we want to write
3193-
* @prev_bio_flags: flags of previous bio to see if we can merge the current one
3192+
* @pg_offset: starting offset in the page
31943193
* @bio_flags: flags of the current bio to see if we can merge them
31953194
*
31963195
* Attempt to add a page to bio considering stripe alignment etc.

fs/btrfs/space-info.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1588,7 +1588,7 @@ static int __reserve_bytes(struct btrfs_fs_info *fs_info,
15881588
/**
15891589
* Trye to reserve metadata bytes from the block_rsv's space
15901590
*
1591-
* @root: the root we're allocating for
1591+
* @fs_info: the filesystem
15921592
* @block_rsv: block_rsv we're allocating for
15931593
* @orig_bytes: number of bytes we want
15941594
* @flush: whether or not we can flush to make our reservation

0 commit comments

Comments
 (0)