Skip to content

Commit be57855

Browse files
committed
fs/9p: fix dups even in uncached mode
In uncached mode we were still seeing duplicate getattr requests because of aggressive dropping of inodes. Inode "freshness" is guarded by other mechanisms when caches are disabled so this is unnecessary and increases overhead of almost every operation. Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
1 parent 724a084 commit be57855

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

fs/9p/vfs_super.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -244,21 +244,6 @@ static int v9fs_statfs(struct dentry *dentry, struct kstatfs *buf)
244244
return res;
245245
}
246246

247-
static int v9fs_drop_inode(struct inode *inode)
248-
{
249-
struct v9fs_session_info *v9ses;
250-
251-
v9ses = v9fs_inode2v9ses(inode);
252-
if (v9ses->cache & (CACHE_META|CACHE_LOOSE))
253-
return generic_drop_inode(inode);
254-
/*
255-
* in case of non cached mode always drop the
256-
* inode because we want the inode attribute
257-
* to always match that on the server.
258-
*/
259-
return 1;
260-
}
261-
262247
static int v9fs_write_inode(struct inode *inode,
263248
struct writeback_control *wbc)
264249
{
@@ -293,7 +278,6 @@ static const struct super_operations v9fs_super_ops_dotl = {
293278
.alloc_inode = v9fs_alloc_inode,
294279
.free_inode = v9fs_free_inode,
295280
.statfs = v9fs_statfs,
296-
.drop_inode = v9fs_drop_inode,
297281
.evict_inode = v9fs_evict_inode,
298282
.show_options = v9fs_show_options,
299283
.umount_begin = v9fs_umount_begin,

0 commit comments

Comments
 (0)