Skip to content

Commit bd2db32

Browse files
gregkhstorulf
authored andcommitted
moxart: fix potential use-after-free on remove path
It was reported that the mmc host structure could be accessed after it was freed in moxart_remove(), so fix this by saving the base register of the device and using it instead of the pointer dereference. Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn> Cc: Xin Xiong <xiongx18@fudan.edu.cn> Cc: Xin Tan <tanxin.ctf@gmail.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Yang Li <yang.lee@linux.alibaba.com> Cc: linux-mmc@vger.kernel.org Cc: stable <stable@vger.kernel.org> Reported-by: whitehat002 <hackyzh002@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 379f56c commit bd2db32

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mmc/host/moxart-mmc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,12 +705,12 @@ static int moxart_remove(struct platform_device *pdev)
705705
if (!IS_ERR_OR_NULL(host->dma_chan_rx))
706706
dma_release_channel(host->dma_chan_rx);
707707
mmc_remove_host(mmc);
708-
mmc_free_host(mmc);
709708

710709
writel(0, host->base + REG_INTERRUPT_MASK);
711710
writel(0, host->base + REG_POWER_CONTROL);
712711
writel(readl(host->base + REG_CLOCK_CONTROL) | CLK_OFF,
713712
host->base + REG_CLOCK_CONTROL);
713+
mmc_free_host(mmc);
714714

715715
return 0;
716716
}

0 commit comments

Comments
 (0)