Skip to content

Commit bc87bb3

Browse files
Aleksandr Burakovhdeller
authored andcommitted
fbdev: viafb: fix typo in hw_bitblt_1 and hw_bitblt_2
There are some actions with value 'tmp' but 'dst_addr' is checked instead. It is obvious that a copy-paste error was made here and the value of variable 'tmp' should be checked here. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Aleksandr Burakov <a.burakov@rosalinux.ru> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 9741917 commit bc87bb3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/video/fbdev/via/accel.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ static int hw_bitblt_1(void __iomem *engine, u8 op, u32 width, u32 height,
115115

116116
if (op != VIA_BITBLT_FILL) {
117117
tmp = src_mem ? 0 : src_addr;
118-
if (dst_addr & 0xE0000007) {
118+
if (tmp & 0xE0000007) {
119119
printk(KERN_WARNING "hw_bitblt_1: Unsupported source "
120120
"address %X\n", tmp);
121121
return -EINVAL;
@@ -260,7 +260,7 @@ static int hw_bitblt_2(void __iomem *engine, u8 op, u32 width, u32 height,
260260
writel(tmp, engine + 0x18);
261261

262262
tmp = src_mem ? 0 : src_addr;
263-
if (dst_addr & 0xE0000007) {
263+
if (tmp & 0xE0000007) {
264264
printk(KERN_WARNING "hw_bitblt_2: Unsupported source "
265265
"address %X\n", tmp);
266266
return -EINVAL;

0 commit comments

Comments
 (0)