Skip to content

Commit bb2243f

Browse files
Hou TaoAlexei Starovoitov
authored andcommitted
bpf: Check map->record at the beginning of check_and_free_fields()
When there are no special fields in the map value, there is no need to invoke bpf_obj_free_fields(). Therefore, checking the validity of map->record in advance. After the change, the benchmark result of the per-cpu update case in map_perf_test increased by 40% under a 16-CPU VM. Signed-off-by: Hou Tao <houtao1@huawei.com> Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> Link: https://lore.kernel.org/r/20250315150930.1511727-1-houtao@huaweicloud.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
1 parent 8c10109 commit bb2243f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

kernel/bpf/hashtab.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,9 @@ static int htab_lru_map_gen_lookup(struct bpf_map *map,
787787
static void check_and_free_fields(struct bpf_htab *htab,
788788
struct htab_elem *elem)
789789
{
790+
if (IS_ERR_OR_NULL(htab->map.record))
791+
return;
792+
790793
if (htab_is_percpu(htab)) {
791794
void __percpu *pptr = htab_elem_get_ptr(elem, htab->map.key_size);
792795
int cpu;

0 commit comments

Comments
 (0)