Skip to content

Commit ba51738

Browse files
committed
crypto: geniv - Split geniv out of AEAD Kconfig option
Give geniv its own Kconfig option so that its dependencies are distinct from that of the AEAD API code. This also allows it to be disabled if no IV generators (seqiv/echainiv) are enabled. Remove the obsolete select on RNG2 by SKCIPHER2 as skcipher IV generators disappeared long ago. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent fb28fab commit ba51738

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

crypto/Kconfig

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ config CRYPTO_AEAD
7171
config CRYPTO_AEAD2
7272
tristate
7373
select CRYPTO_ALGAPI2
74-
select CRYPTO_NULL2
75-
select CRYPTO_RNG2
7674

7775
config CRYPTO_SKCIPHER
7876
tristate
@@ -82,7 +80,6 @@ config CRYPTO_SKCIPHER
8280
config CRYPTO_SKCIPHER2
8381
tristate
8482
select CRYPTO_ALGAPI2
85-
select CRYPTO_RNG2
8683

8784
config CRYPTO_HASH
8885
tristate
@@ -834,13 +831,16 @@ config CRYPTO_GCM
834831

835832
This is required for IPSec ESP (XFRM_ESP).
836833

837-
config CRYPTO_SEQIV
838-
tristate "Sequence Number IV Generator"
834+
config CRYPTO_GENIV
835+
tristate
839836
select CRYPTO_AEAD
840-
select CRYPTO_SKCIPHER
841837
select CRYPTO_NULL
842-
select CRYPTO_RNG_DEFAULT
843838
select CRYPTO_MANAGER
839+
select CRYPTO_RNG_DEFAULT
840+
841+
config CRYPTO_SEQIV
842+
tristate "Sequence Number IV Generator"
843+
select CRYPTO_GENIV
844844
help
845845
Sequence Number IV generator
846846

@@ -851,10 +851,7 @@ config CRYPTO_SEQIV
851851

852852
config CRYPTO_ECHAINIV
853853
tristate "Encrypted Chain IV Generator"
854-
select CRYPTO_AEAD
855-
select CRYPTO_NULL
856-
select CRYPTO_RNG_DEFAULT
857-
select CRYPTO_MANAGER
854+
select CRYPTO_GENIV
858855
help
859856
Encrypted Chain IV generator
860857

crypto/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ crypto_algapi-y := algapi.o scatterwalk.o $(crypto_algapi-y)
1414
obj-$(CONFIG_CRYPTO_ALGAPI2) += crypto_algapi.o
1515

1616
obj-$(CONFIG_CRYPTO_AEAD2) += aead.o
17-
obj-$(CONFIG_CRYPTO_AEAD2) += geniv.o
17+
obj-$(CONFIG_CRYPTO_GENIV) += geniv.o
1818

1919
obj-$(CONFIG_CRYPTO_SKCIPHER2) += skcipher.o
2020
obj-$(CONFIG_CRYPTO_SEQIV) += seqiv.o

0 commit comments

Comments
 (0)