Skip to content

Commit b856101

Browse files
MarkZhang81jgunthorpe
authored andcommitted
IB/cm: Release previously acquired reference counter in the cm_id_priv
In failure flow, the reference counter acquired was not released, and the following error was reported: drivers/infiniband/core/cm.c:3373 cm_lap_handler() warn: inconsistent refcounting 'cm_id_priv->refcount.refs.counter': Fixes: 7345201 ("IB/cm: Improve the calling of cm_init_av_for_lap and cm_init_av_by_path") Link: https://lore.kernel.org/r/7615f23bbb5c5b66d03f6fa13e1c99d51dae6916.1642581448.git.leonro@nvidia.com Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mark Zhang <markzhang@nvidia.com> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
1 parent a75bade commit b856101

File tree

1 file changed

+1
-1
lines changed
  • drivers/infiniband/core

1 file changed

+1
-1
lines changed

drivers/infiniband/core/cm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3322,7 +3322,7 @@ static int cm_lap_handler(struct cm_work *work)
33223322
ret = cm_init_av_by_path(param->alternate_path, NULL, &alt_av);
33233323
if (ret) {
33243324
rdma_destroy_ah_attr(&ah_attr);
3325-
return -EINVAL;
3325+
goto deref;
33263326
}
33273327

33283328
spin_lock_irq(&cm_id_priv->lock);

0 commit comments

Comments
 (0)