Skip to content

Commit b7bcffe

Browse files
author
Ingo Molnar
committed
x86/vdso/kbuild: Group non-standard build attributes and primary object file rules together
The fresh changes to the vDSO Makefile in: 289d0a4 ("x86/vdso: Use CONFIG_COMPAT_32 to specify vdso32") 329b77b ("x86/vdso: Simplify obj-y addition") Conflicted with a pending change in: b388e57 ("x86/vdso: Fix rethunk patching for vdso-image-{32,64}.o") Which was resolved in a simple fasion in this merge commit: f14df82 ("Merge branch 'x86/vdso' into x86/core, to resolve conflict and to prepare for dependent changes") ... but all these changes make me look and notice a bit of historic baggage left in the Makefile: - Disordered build rules where non-standard build attributes relating to were placed sometimes several lines after - and sometimes *before* the .o build rules of the object files... Functional but inconsistent. - Inconsistent vertical spacing, stray whitespaces, inconsistent spelling of 'vDSO' over the years, a few spelling mistakes and inconsistent capitalization of comment blocks. Tidy it all up. No functional changes intended. Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Borislav Petkov (AMD) <bp@alien8.de> Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent f14df82 commit b7bcffe

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

arch/x86/entry/vdso/Makefile

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Building vDSO images for x86.
44
#
55

6-
# Include the generic Makefile to check the built vdso.
6+
# Include the generic Makefile to check the built vDSO:
77
include $(srctree)/lib/vdso/Makefile
88

99
# Sanitizer runtimes are unavailable and cannot be linked here.
@@ -18,29 +18,29 @@ OBJECT_FILES_NON_STANDARD := y
1818
# Prevents link failures: __sanitizer_cov_trace_pc() is not linked in.
1919
KCOV_INSTRUMENT := n
2020

21-
# files to link into the vdso
21+
# Files to link into the vDSO:
2222
vobjs-y := vdso-note.o vclock_gettime.o vgetcpu.o
2323
vobjs32-y := vdso32/note.o vdso32/system_call.o vdso32/sigreturn.o
2424
vobjs32-y += vdso32/vclock_gettime.o vdso32/vgetcpu.o
2525
vobjs-$(CONFIG_X86_SGX) += vsgx.o
2626

27-
# files to link into kernel
28-
obj-y += vma.o extable.o
29-
KASAN_SANITIZE_vma.o := y
30-
UBSAN_SANITIZE_vma.o := y
31-
KCSAN_SANITIZE_vma.o := y
27+
# Files to link into the kernel:
28+
obj-y += vma.o extable.o
29+
KASAN_SANITIZE_vma.o := y
30+
UBSAN_SANITIZE_vma.o := y
31+
KCSAN_SANITIZE_vma.o := y
3232

33-
OBJECT_FILES_NON_STANDARD_extable.o := n
34-
OBJECT_FILES_NON_STANDARD_vdso-image-32.o := n
35-
OBJECT_FILES_NON_STANDARD_vdso-image-64.o := n
3633
OBJECT_FILES_NON_STANDARD_vma.o := n
34+
OBJECT_FILES_NON_STANDARD_extable.o := n
3735

38-
# vDSO images to build
39-
obj-$(CONFIG_X86_64) += vdso-image-64.o
40-
obj-$(CONFIG_X86_X32_ABI) += vdso-image-x32.o
41-
obj-$(CONFIG_COMPAT_32) += vdso-image-32.o vdso32-setup.o
36+
# vDSO images to build:
37+
obj-$(CONFIG_X86_64) += vdso-image-64.o
38+
obj-$(CONFIG_X86_X32_ABI) += vdso-image-x32.o
39+
obj-$(CONFIG_COMPAT_32) += vdso-image-32.o vdso32-setup.o
4240

43-
OBJECT_FILES_NON_STANDARD_vdso32-setup.o := n
41+
OBJECT_FILES_NON_STANDARD_vdso-image-32.o := n
42+
OBJECT_FILES_NON_STANDARD_vdso-image-64.o := n
43+
OBJECT_FILES_NON_STANDARD_vdso32-setup.o := n
4444

4545
vobjs := $(addprefix $(obj)/, $(vobjs-y))
4646
vobjs32 := $(addprefix $(obj)/, $(vobjs32-y))

0 commit comments

Comments
 (0)